tanelk commented on a change in pull request #30018:
URL: https://github.com/apache/spark/pull/30018#discussion_r509003317
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
##########
@@ -477,6 +478,25 @@ object RemoveRedundantAliases extends Rule[LogicalPlan] {
def apply(plan: LogicalPlan): LogicalPlan = removeRedundantAliases(plan,
AttributeSet.empty)
}
+/**
+ * Remove redundant aggregates from a query plan. A redundant aggregate is an
aggregate whose
+ * only goal is to keep distinct values, while its parent aggregate would
ignore duplicate values.
+ */
+object RemoveRedundantAggregates extends Rule[LogicalPlan] {
+ def apply(plan: LogicalPlan): LogicalPlan = plan transformUp {
Review comment:
For example the UT `Remove 2 redundant aggregates`.
With `transformUp` it runs 2 iterations (1 extra to detect that all changes
are done).
With `transformDown` it runs 3 iterations
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
