HyukjinKwon commented on pull request #29992: URL: https://github.com/apache/spark/pull/29992#issuecomment-713345672
That's good. I just wonder if we can just: - `blockManagerInfo.contains(...)` instead of catching `java.util.NoSuchElementException` - Check if something is null, and just ignore instead of catching `java.lang.NullPointerException` I don't believe catching `java.lang.NullPointerException` in a block is a good practice because it will catch all NPE that can potentially happen everywhere. Would you mind if I ask the stacktrace? At least I want to understand why catching NPE is necessary even if I fail to make a fix. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
