maropu commented on a change in pull request #29982:
URL: https://github.com/apache/spark/pull/29982#discussion_r509241110
##########
File path:
sql/hive-thriftserver/src/main/scala/org/apache/spark/sql/hive/thriftserver/SparkSQLCLIDriver.scala
##########
@@ -519,14 +519,22 @@ private[hive] class SparkSQLCLIDriver extends CliDriver
with Logging {
// Note: [SPARK-31595] if there is a `'` in a double quoted string, or a `"`
in a single quoted
// string, the origin implementation from Hive will not drop the trailing
semicolon as expected,
// hence we refined this function a little bit.
+ // Note: [SPARK-33100] Ignore a semicolon inside a bracketed comment in
spark-sql.
private def splitSemiColon(line: String): JList[String] = {
var insideSingleQuote = false
var insideDoubleQuote = false
- var insideComment = false
+ var insideSimpleComment = false
+ var bracketedCommentLevel = 0
var escape = false
var beginIndex = 0
+ var includingStatement = false
val ret = new JArrayList[String]
+ def insideBracketedComment: Boolean = bracketedCommentLevel > 0
Review comment:
Ah, ... I notice that handling bracketed comments is more complicated
than I thought. For example, `SELECT /*+ COALESCE(3) */ * FROM t`. In this
case, we need to pass the comment into the Spark parser.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
