maropu commented on pull request #29497: URL: https://github.com/apache/spark/pull/29497#issuecomment-714050304
> In the ideal case, all exception messages should be grouped for easy maintenance and auditing. This PR first starts from the AnalyzerExceptions in Catalyst. And yeah, if we want to divide these exceptions in groups, then the mapping rule, and how to divide so that contributors can easily follow the rule to commit is a problem. And, another concern of the QueryCompilationErrors and QueryExecutionErrors is that they are different package names + same object name. When developers would like to call functions of compilation errors from different components, they may have to write the full package name. >> This is a good point. Is it possible that we put all the error messages in the catalyst module? Other modules depend on catalyst and can access error messages. Any update? I think its okay to target at grouping `AnalyzerExceptions` first in this PR and follow the @cloud-fan suggestion above. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
