cloud-fan commented on a change in pull request #29817:
URL: https://github.com/apache/spark/pull/29817#discussion_r509857454
##########
File path:
core/src/main/scala/org/apache/spark/executor/CoarseGrainedExecutorBackend.scala
##########
@@ -166,17 +171,6 @@ private[spark] class CoarseGrainedExecutorBackend(
if (executor == null) {
exitExecutor(1, "Received LaunchTask command but executor was null")
} else {
- if (decommissioned) {
- val msg = "Asked to launch a task while decommissioned."
- logError(msg)
- driver match {
- case Some(endpoint) =>
- logInfo("Sending DecommissionExecutor to driver.")
- endpoint.send(DecommissionExecutor(executorId,
ExecutorDecommissionInfo(msg)))
- case _ =>
- logError("No registered driver to send Decommission to.")
- }
- }
Review comment:
Yea I don't see the point of resending the notice to the driver,
especially in this race condition. If we want to make sure the driver is
noticed, we should design a mechanism for it, instead of doing it here randomly.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
