Github user chenghao-intel commented on a diff in the pull request:
https://github.com/apache/spark/pull/4015#discussion_r28039065
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/SQLContext.scala ---
@@ -129,19 +191,33 @@ class SQLContext(@transient val sparkContext:
SparkContext)
@transient
protected[sql] lazy val optimizer: Optimizer = DefaultOptimizer
- @transient
- protected[sql] val ddlParser = new DDLParser(sqlParser.apply(_))
-
- @transient
- protected[sql] val sqlParser = {
- val fallback = new catalyst.SqlParser
- new SparkSQLParser(fallback(_))
+ protected[sql] def dialectCache = tlSession.get().dialectCache
+ protected[sql] def setDialectCache(d: SQLDialect) = {
+ tlSession.get().dialectCache = d
}
- protected[sql] def parseSql(sql: String): LogicalPlan = {
- ddlParser(sql, false).getOrElse(sqlParser(sql))
+ protected[sql] def getSQLDialect(): SQLDialect = {
+ try {
+ val clazz = Utils.classForName(dialectClassName)
+ if (dialectCache == null || dialectCache.getClass != clazz) {
+
setDialectCache(clazz.newInstance().asInstanceOf[SQLDialect].initialize(this))
+ }
+
+ dialectCache
--- End diff --
Actually I didn't add this previously, but I ran into the unit test
failure, `timeout` for some queries. I will add some comment here.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
