cloud-fan commented on a change in pull request #28938:
URL: https://github.com/apache/spark/pull/28938#discussion_r509998660
##########
File path:
sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveExternalCatalog.scala
##########
@@ -95,11 +100,20 @@ private[spark] class HiveExternalCatalog(conf: SparkConf,
hadoopConf: Configurat
}
/**
- * Run some code involving `client` in a [[synchronized]] block and wrap
certain
+ * Run some code involving `client` in a [[ReadWriteLock]] and wrap certain
* exceptions thrown in the process in [[AnalysisException]].
+ *
+ * @param db to specify the place of the operation act on.
+ * @param writeLock to specify it is a write lock.
*/
- private def withClient[T](body: => T): T = synchronized {
+ private def withClient[T](db: String = "", writeLock: Boolean = false)
(body: => T): T = {
Review comment:
Interesting. If it's thread-local, then `HiveExternalCatalog.client`
should be thread-safe? Or these hive clients that in different threads still
share something?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
