Github user chenghao-intel commented on a diff in the pull request:
https://github.com/apache/spark/pull/5433#discussion_r28103100
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/joins/HashedRelation.scala
---
@@ -55,6 +82,14 @@ private[joins] final class
UniqueKeyHashedRelation(hashTable: JavaHashMap[Row, R
}
def getValue(key: Row): Row = hashTable.get(key)
+
+ override def writeExternal(out: ObjectOutput): Unit = {
+ writeBytes(out, SparkSqlSerializer.serialize(hashTable))
--- End diff --
This is probably very huge for `SparkSqlSerializer.serialize(hashTable)`,
as in `ShuffledHashJoin`, we will load the whole partition data into the
`hashTable`, which mean we probably keep 2 copies of the data in the memory,
will that the intention?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
