leanken commented on a change in pull request #30097:
URL: https://github.com/apache/spark/pull/30097#discussion_r510548134
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/ResolveInlineTables.scala
##########
@@ -28,7 +28,8 @@ import org.apache.spark.sql.types.{StructField, StructType}
/**
* An analyzer rule that replaces [[UnresolvedInlineTable]] with
[[LocalRelation]].
*/
-case class ResolveInlineTables(conf: SQLConf) extends Rule[LogicalPlan] with
CastSupport {
+object ResolveInlineTables extends Rule[LogicalPlan] with CastSupport {
+ override def conf: SQLConf = SQLConf.get
Review comment:
If it's final and could not be override, and in its subclass the usage
difference would be conf.XXX and SQLConf.get.XXX, I don't think we should
bother to add such interface. ^_^
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
