cloud-fan commented on a change in pull request #30079:
URL: https://github.com/apache/spark/pull/30079#discussion_r510587663
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/v2ResolutionPlans.scala
##########
@@ -81,7 +81,7 @@ case class ResolvedTable(catalog: TableCatalog, identifier:
Identifier, table: T
*/
// TODO: create a generic representation for temp view, v1 view and v2 view,
after we add view
// support to v2 catalog. For now we only need the identifier to
fallback to v1 command.
-case class ResolvedView(identifier: Identifier) extends LeafNode {
+case class ResolvedView(identifier: Identifier, isTempView: Boolean) extends
LeafNode {
Review comment:
nit: the class name is `ResolvedView`, so the flag can be named as
`isTemp`, as we are already in the context of view.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
