cloud-fan commented on a change in pull request #29339:
URL: https://github.com/apache/spark/pull/29339#discussion_r510730748



##########
File path: 
sql/core/src/test/scala/org/apache/spark/sql/connector/DataSourceV2SQLSuite.scala
##########
@@ -74,6 +76,7 @@ class DataSourceV2SQLSuite
 
   before {
     spark.conf.set("spark.sql.catalog.testcat", 
classOf[InMemoryTableCatalog].getName)
+    spark.conf.set("spark.sql.catalog.testpart", 
classOf[InMemoryPartitionTableCatalog].getName)

Review comment:
       This suite is growing too big. Can we create a 
`AlterTablePartitionV2Suite` to put the new tests? We can also create a base 
trait for v2 tests, so that it can be shared between `DataSourceV2SQLSuite` and 
the new `AlterTablePartitionV2Suite`.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to