otterc commented on a change in pull request #30062:
URL: https://github.com/apache/spark/pull/30062#discussion_r511675412
##########
File path:
common/network-yarn/src/main/java/org/apache/spark/network/yarn/YarnShuffleService.java
##########
@@ -172,7 +178,9 @@ protected void serviceInit(Configuration conf) throws
Exception {
}
TransportConf transportConf = new TransportConf("shuffle", new
HadoopConfigProvider(conf));
- blockHandler = new ExternalBlockHandler(transportConf,
registeredExecutorFile);
+ shuffleMergeManager = new RemoteBlockPushResolver(transportConf,
APP_BASE_RELATIVE_PATH);
Review comment:
@Ngone51 , @tgravescs , @Victsm
I will add a configuration on the server side that will disable push-based
shuffle on the server.
@tgravescs Do you think the custom implementation can be a follow-up task? I
have create this jira https://issues.apache.org/jira/browse/SPARK-33235 for all
the follow-up tasks. I will add the custom implementation as a subtask as well.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
