Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/5451#discussion_r28194336
--- Diff:
yarn/src/main/scala/org/apache/spark/scheduler/cluster/YarnClientSchedulerBackend.scala
---
@@ -124,27 +124,32 @@ private[spark] class YarnClientSchedulerBackend(
* If the application has exited for any reason, stop the SparkContext.
* This assumes both `client` and `appId` have already been set.
*/
- private def asyncMonitorApplication(): Thread = {
+ private def asyncMonitorApplication(): MonitorApplicationThread = {
assert(client != null && appId != null, "Application has not been
submitted yet!")
- val t = new Thread {
- override def run() {
- val (state, _) = client.monitorApplication(appId,
logApplicationReport = false)
- logError(s"Yarn application has already exited with state $state!")
- sc.stop()
- Thread.currentThread().interrupt()
- }
- }
+ val t = new MonitorApplicationThread()
t.setName("Yarn application state monitor")
t.setDaemon(true)
t
}
+ private class MonitorApplicationThread extends Thread{
+ override def run() {
+ val (state, _) = client.monitorApplication(appId,
logApplicationReport = false)
+ logError(s"Yarn application has already exited with state $state!")
+ sc.stop()
+ Thread.currentThread().interrupt()
+ }
+ def stopMonitor() {
+ client.stopMonitorApplication()
+ }
+ }
+
/**
* Stop the scheduler. This assumes `start()` has already been called.
*/
override def stop() {
assert(client != null, "Attempted to stop this scheduler before
starting it!")
- monitorThread.interrupt()
+ monitorThread.stopMonitor()
--- End diff --
The narrowest fix is just to catch `InterruptedException` here and ignore
it and/or log it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
