viirya commented on a change in pull request #30138:
URL: https://github.com/apache/spark/pull/30138#discussion_r511746390
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/CacheManager.scala
##########
@@ -79,10 +92,11 @@ class CacheManager extends Logging with
AdaptiveSparkPlanHelper {
if (lookupCachedData(planToCache).nonEmpty) {
logWarning("Asked to cache already cached data.")
} else {
- // Turn off AQE so that the outputPartitioning of the underlying plan
can be leveraged.
- val sessionWithAqeOff = getOrCloneSessionWithAqeOff(query.sparkSession)
- val inMemoryRelation = sessionWithAqeOff.withActive {
- val qe = sessionWithAqeOff.sessionState.executePlan(planToCache)
+ // Turn off configs so that the outputPartitioning of the underlying
plan can be leveraged.
Review comment:
nit: this comment seems duplicated with above.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
