zero323 commented on pull request #30143: URL: https://github.com/apache/spark/pull/30143#issuecomment-716352745
> Yeah, I think we can just keep docstrings as-is. For grouping stuff, I think it's okay to don't change since it's mainly for code readers. That's true, though I'd argue that it matters, given the size of the module (it is large enough, so `log` defined twice, once through dict and once through def, went unnoticed for years) Not to mention it was clearly the original intention, things just diverged a bit over time. > There were similar changes proposed (and abandoned) before, e.g.) #27976. Fair enough. Let's not complicate things here, but I'll allow myself another PR later to see if I can make the case :) ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
