cloud-fan commented on a change in pull request #30142:
URL: https://github.com/apache/spark/pull/30142#discussion_r511815463



##########
File path: 
sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala
##########
@@ -2858,6 +2858,14 @@ object SQLConf {
     .stringConf
     .createWithDefault("")
 
+  val JDBC_MYSQL_VERSION =
+    buildConf("spark.sql.jdbc.mysql.version")

Review comment:
       what if users want to connect to both mysql 5 and 8? I think it's better 
to make it a catalog option, not a session config.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to