Github user srowen commented on a diff in the pull request:

    https://github.com/apache/spark/pull/5236#discussion_r28196560
  
    --- Diff: core/src/main/scala/org/apache/spark/SparkConf.scala ---
    @@ -174,6 +174,35 @@ class SparkConf(loadDefaults: Boolean) extends 
Cloneable with Logging {
         getOption(key).getOrElse(defaultValue)
       }
     
    +  /** Get a time parameter as seconds; throws a NoSuchElementException if 
it's not set. If no 
    +    * suffix is provided then seconds are assumed. 
    +    */
    +  def getTimeAsSec(key: String): Long = {
    +    Utils.timeStringAsSec(getOption(key).getOrElse(throw new 
NoSuchElementException(key)))
    --- End diff --
    
    I think you can just call `get(key)` and rely on it to perform exactly this 
logic? (Am I missing some separate discussion we already had on this?)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to