Github user pwendell commented on a diff in the pull request:

    https://github.com/apache/spark/pull/590#discussion_r12112347
  
    --- Diff: project/SparkBuild.scala ---
    @@ -569,7 +569,7 @@ object SparkBuild extends Build {
         libraryDependencies += "net.sf.py4j" % "py4j" % "0.8.1",
         name := "spark-assembly",
         assembleDeps in Compile <<= (packageProjects.map(packageBin in Compile 
in _) ++ Seq(packageDependency in Compile)).dependOn,
    -    jarName in assembly <<= version map { v => "spark-assembly-" + v + 
"-hadoop" + hadoopVersion + ".jar" },
    +    jarName in assembly <<= version map { v => 
s"spark-assembly-${v}-hadoop${hadoopVersion}${if (isYarnEnabled) "-yarn" else 
""}.jar" },
    --- End diff --
    
    I'd prefer to keep this as-is for now. We have many parameters in the build 
(hadoop version, hive support, ganglia, yarn etc) and I don't think it will 
scale to add new suffixes for each one.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to