leanken commented on a change in pull request #30097:
URL: https://github.com/apache/spark/pull/30097#discussion_r512385606
##########
File path:
sql/hive/src/main/scala/org/apache/spark/sql/hive/execution/PruneHiveTablePartitions.scala
##########
@@ -27,7 +27,8 @@ import
org.apache.spark.sql.catalyst.planning.PhysicalOperation
import org.apache.spark.sql.catalyst.plans.logical.{Filter, LogicalPlan,
Project}
import org.apache.spark.sql.catalyst.rules.Rule
import org.apache.spark.sql.execution.datasources.DataSourceStrategy
-import org.apache.spark.sql.internal.SQLConf
+
+private[sql] class PruneHiveTablePartitions
Review comment:
done
##########
File path:
sql/core/src/test/scala/org/apache/spark/sql/sources/DataSourceAnalysisSuite.scala
##########
@@ -196,6 +202,7 @@ class DataSourceAnalysisSuite extends SparkFunSuite with
BeforeAndAfterAll {
}
test(s"Static partition and dynamic partition (caseSensitive:
$caseSensitive)") {
+ SQLConf.get.setConf(SQLConf.CASE_SENSITIVE, caseSensitive)
Review comment:
done
##########
File path:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/optimizer/EliminateSortsSuite.scala
##########
@@ -32,7 +32,8 @@ import org.apache.spark.sql.internal.SQLConf.{CASE_SENSITIVE,
ORDER_BY_ORDINAL}
import org.apache.spark.sql.types.IntegerType
class EliminateSortsSuite extends PlanTest {
- override val conf = new SQLConf().copy(CASE_SENSITIVE -> true,
ORDER_BY_ORDINAL -> false)
+ SQLConf.get.setConf(CASE_SENSITIVE, true)
+ SQLConf.get.setConf(ORDER_BY_ORDINAL, false)
Review comment:
done
##########
File path:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/optimizer/AggregateOptimizeSuite.scala
##########
@@ -29,7 +29,8 @@ import org.apache.spark.sql.internal.SQLConf
import org.apache.spark.sql.internal.SQLConf.{CASE_SENSITIVE, GROUP_BY_ORDINAL}
class AggregateOptimizeSuite extends PlanTest {
- override val conf = new SQLConf().copy(CASE_SENSITIVE -> false,
GROUP_BY_ORDINAL -> false)
+ SQLConf.get.setConf(CASE_SENSITIVE, false)
+ SQLConf.get.setConf(GROUP_BY_ORDINAL, false)
Review comment:
done
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
