beliefer commented on a change in pull request #29800:
URL: https://github.com/apache/spark/pull/29800#discussion_r512478210
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/window/WindowExecBase.scala
##########
@@ -171,18 +178,42 @@ trait WindowExecBase extends UnaryExecNode {
// Create the factory to produce WindowFunctionFrame.
val factory = key match {
- // Offset Frame
- case ("OFFSET", _, IntegerLiteral(offset), _) =>
+ // Frameless offset Frame
+ case ("FRAME_LESS_OFFSET", _, IntegerLiteral(offset), _) =>
target: InternalRow =>
- new OffsetWindowFunctionFrame(
+ new FrameLessOffsetWindowFunctionFrame(
target,
ordinal,
// OFFSET frame functions are guaranteed be
OffsetWindowFunctions.
Review comment:
OK
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/window/WindowExecBase.scala
##########
@@ -171,18 +178,42 @@ trait WindowExecBase extends UnaryExecNode {
// Create the factory to produce WindowFunctionFrame.
val factory = key match {
- // Offset Frame
- case ("OFFSET", _, IntegerLiteral(offset), _) =>
+ // Frameless offset Frame
+ case ("FRAME_LESS_OFFSET", _, IntegerLiteral(offset), _) =>
target: InternalRow =>
- new OffsetWindowFunctionFrame(
+ new FrameLessOffsetWindowFunctionFrame(
target,
ordinal,
// OFFSET frame functions are guaranteed be
OffsetWindowFunctions.
- functions.map(_.asInstanceOf[OffsetWindowFunction]),
+ functions.map(_.asInstanceOf[OffsetWindowSpec]),
child.output,
(expressions, schema) =>
MutableProjection.create(expressions, schema),
offset)
+ case ("UNBOUNDED_OFFSET", _, IntegerLiteral(offset), _) =>
+ target: InternalRow => {
+ new UnboundedOffsetWindowFunctionFrame(
+ target,
+ ordinal,
+ // OFFSET frame functions are guaranteed be
OffsetWindowFunctions.
Review comment:
OK
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/window/WindowExecBase.scala
##########
@@ -171,18 +178,42 @@ trait WindowExecBase extends UnaryExecNode {
// Create the factory to produce WindowFunctionFrame.
val factory = key match {
- // Offset Frame
- case ("OFFSET", _, IntegerLiteral(offset), _) =>
+ // Frameless offset Frame
+ case ("FRAME_LESS_OFFSET", _, IntegerLiteral(offset), _) =>
target: InternalRow =>
- new OffsetWindowFunctionFrame(
+ new FrameLessOffsetWindowFunctionFrame(
target,
ordinal,
// OFFSET frame functions are guaranteed be
OffsetWindowFunctions.
- functions.map(_.asInstanceOf[OffsetWindowFunction]),
+ functions.map(_.asInstanceOf[OffsetWindowSpec]),
child.output,
(expressions, schema) =>
MutableProjection.create(expressions, schema),
offset)
+ case ("UNBOUNDED_OFFSET", _, IntegerLiteral(offset), _) =>
+ target: InternalRow => {
+ new UnboundedOffsetWindowFunctionFrame(
+ target,
+ ordinal,
+ // OFFSET frame functions are guaranteed be
OffsetWindowFunctions.
+ functions.map(_.asInstanceOf[OffsetWindowSpec]),
+ child.output,
+ (expressions, schema) =>
+ MutableProjection.create(expressions, schema),
+ offset - 1)
+ }
+ case ("UNBOUNDED_PRECEDING_OFFSET", _, IntegerLiteral(offset), _) =>
+ target: InternalRow => {
+ new UnboundedPrecedingOffsetWindowFunctionFrame(
+ target,
+ ordinal,
+ // OFFSET frame functions are guaranteed be
OffsetWindowFunctions.
Review comment:
OK
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
