maropu commented on pull request #30134: URL: https://github.com/apache/spark/pull/30134#issuecomment-717255473
> There were some places, but I did not feel that they deserved to get a method extracted. For example: https://github.com/tanelk/spark/blob/63abab41b40e98947a5cb340a966e657e6b03632/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala#L3741 okay, thanks for the check. LGTM. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
