HeartSaVioR commented on pull request #30151: URL: https://github.com/apache/spark/pull/30151#issuecomment-717635077
> How do you exactly mean separate? I meant having "accumulated" graphs across multiple state stores vs having graphs per state store. If you use stream-stream join, 12 (6 * 2) graphs will come up, and to see the overall memory usage end users have to accumulate these values by theirselves. Having graphs per state store may be helpful on stream-stream join when there's a skew between left side and right side (either volume of the inputs or difference on evict condition), but probably can be hidden by default and shown on demand of "details". (separate page?) Btw I guess loadedMapCacheHitCount graph can be dropped unless on demand, as if things are working without crash or Spark's bug it will always increment properly. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
