ScrapCodes commented on a change in pull request #27735: URL: https://github.com/apache/spark/pull/27735#discussion_r513239026
########## File path: resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/submit/KubernetesClientUtils.scala ########## @@ -0,0 +1,124 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.spark.deploy.k8s.submit + +import java.io.{File, StringWriter} +import java.util.Properties + +import scala.collection.JavaConverters._ +import scala.io.{Codec, Source} + +import io.fabric8.kubernetes.api.model.{ConfigMap, ConfigMapBuilder, KeyToPath} + +import org.apache.spark.SparkConf +import org.apache.spark.deploy.k8s.{Constants, KubernetesUtils} +import org.apache.spark.deploy.k8s.Constants.ENV_SPARK_CONF_DIR +import org.apache.spark.internal.Logging + +private[spark] object KubernetesClientUtils extends Logging { Review comment: Hi @holdenk , thank you for taking a look. I can go ahead and merge this with `KubernetesUtils`, I have kept it separate as `KubernetesUtils` has already grown up a bit and the helper functions here are mostly the one used by `KubernetesClientApplication` or the `submit` package. I do not have a strong opinion, that this should stay separate and it should be named `KubernetesClientUtils`. What do you think? Shall I just go ahead and merge this, with KubernetesUtils ? any other suggestion? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
