cloud-fan commented on a change in pull request #29882:
URL: https://github.com/apache/spark/pull/29882#discussion_r513557495
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/arithmetic.scala
##########
@@ -320,15 +339,22 @@ trait DivModLike extends BinaryArithmetic {
override def nullable: Boolean = true
+ private lazy val isZero: Any => Boolean = right.dataType match {
+ case _: DecimalType => x => x.asInstanceOf[Decimal].isZero
+ case _ => x => x == 0
+ }
+
final override def eval(input: InternalRow): Any = {
+ // evaluate right first as we have a chance to skip left if right is 0
val input2 = right.eval(input)
- if (input2 == null || input2 == 0) {
+ if (input2 == null || (!failOnError && isZero(input2))) {
null
} else {
val input1 = left.eval(input)
if (input1 == null) {
null
} else {
+ if (isZero(input2)) throw new ArithmeticException("divide by zero")
Review comment:
nit: add a comment `when we reach here, failOnError must bet true.`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
