zero323 commented on a change in pull request #30181:
URL: https://github.com/apache/spark/pull/30181#discussion_r514334554
##########
File path: python/pyspark/sql/dataframe.pyi
##########
@@ -237,13 +237,16 @@ class DataFrame(PandasMapOpsMixin, PandasConversionMixin):
subset: Optional[List[str]] = ...,
) -> DataFrame: ...
def approxQuantile(
- self, col: str, probabilities: List[float], relativeError: float
+ self,
+ col: Union[str, Tuple[str, ...], List[str]],
+ probabilities: Union[List[float], Tuple[float]],
+ relativeError: Union[int, float]
Review comment:
In general `int` objects are valid substitutions for `float`, so I'd
probably avoid listing them explicitly, unless they're treated differently.
##########
File path: python/pyspark/sql/dataframe.pyi
##########
@@ -237,13 +237,16 @@ class DataFrame(PandasMapOpsMixin, PandasConversionMixin):
subset: Optional[List[str]] = ...,
) -> DataFrame: ...
def approxQuantile(
- self, col: str, probabilities: List[float], relativeError: float
+ self,
+ col: Union[str, Tuple[str, ...], List[str]],
+ probabilities: Union[List[float], Tuple[float]],
Review comment:
I think we're missing ellipsis in `Tuple`:
```python
Tuple[float, ...]
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
