HeartSaVioR commented on a change in pull request #26935:
URL: https://github.com/apache/spark/pull/26935#discussion_r514596151
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/state/StateStoreRDD.scala
##########
@@ -29,14 +29,51 @@ import org.apache.spark.sql.internal.SessionState
import org.apache.spark.sql.types.StructType
import org.apache.spark.util.SerializableConfiguration
+// This doesn't directly override RDD methods as MiMa complains it.
+abstract class BaseStateStoreRDD[T: ClassTag, U: ClassTag](
+ dataRDD: RDD[T],
+ checkpointLocation: String,
+ queryRunId: UUID,
+ operatorId: Long,
+ sessionState: SessionState,
+ @transient private val storeCoordinator: Option[StateStoreCoordinatorRef],
+ extraOptions: Map[String, String] = Map.empty) extends RDD[U](dataRDD) {
+
+ protected val storeConf = new StateStoreConf(sessionState.conf, extraOptions)
+
+ // A Hadoop Configuration can be about 10 KB, which is pretty big, so
broadcast it
+ protected val hadoopConfBroadcast = dataRDD.context.broadcast(
+ new SerializableConfiguration(sessionState.newHadoopConf()))
+
+ /** Implementations can simply call this method in getPreferredLocations. */
+ protected def _getPartitions: Array[Partition] = dataRDD.partitions
Review comment:
I wouldn't want to touch RDD side just because of this change, which may
bring unnecessary additional discussion. I don't see this as a kind of blocker
for this PR. Anyone can deal with this as a follow-up, with possibility of
discussion.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
