huaxingao commented on a change in pull request #30154:
URL: https://github.com/apache/spark/pull/30154#discussion_r514657593
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/jdbc/JDBCTableCatalog.scala
##########
@@ -123,8 +123,14 @@ class JDBCTableCatalog extends TableCatalog with Logging {
"ignored: " + properties.asScala.map { case (k, v) => s"$k=$v"
}.mkString("[", ", ", "]"))
Review comment:
OK, so we will support `comment` and ignore `provider`, `owner`, and
`location` for now.
For supported table properties, do we need to make them database specific?
for example, `ENGINE` and `CHARSET` are supported table properties for MySQL
but not supported by other databases.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
