imback82 commented on a change in pull request #30079:
URL: https://github.com/apache/spark/pull/30079#discussion_r516901187
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/DataSourceV2Strategy.scala
##########
@@ -228,8 +228,11 @@ class DataSourceV2Strategy(session: SparkSession) extends
Strategy with Predicat
case DescribeColumn(_: ResolvedTable, _, _) =>
throw new AnalysisException("Describing columns is not supported for v2
tables.")
- case DropTable(catalog, ident, ifExists) =>
- DropTableExec(catalog, ident, ifExists) :: Nil
+ case DropTable(r: ResolvedTable, ifExists, _) =>
Review comment:
The `purge` option seems that it should be handled by the catalog
implementation, not by Spark (e.g., `ifExists`). We can update
`TableCatalog.dropTable` to pass an additional flag, or we could introduce
`TableCatalog.purgeTable` for the catalog implementor can optionally implement.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
