otterc commented on a change in pull request #30164:
URL: https://github.com/apache/spark/pull/30164#discussion_r516929549
##########
File path: core/src/main/scala/org/apache/spark/internal/config/package.scala
##########
@@ -1927,4 +1927,34 @@ package object config {
.version("3.0.1")
.booleanConf
.createWithDefault(false)
+
+ private[spark] val PUSH_BASED_SHUFFLE_ENABLED =
+ ConfigBuilder("spark.shuffle.push.enabled")
+ .doc("Set to 'true' to enable push based shuffle")
Review comment:
The documentation here needs to be updated. Since we are adding a
cluster level configuration in https://github.com/apache/spark/pull/30062 to
enable/disable push-based shuffle, client-side configuration documentation
should also reflect that enable this only if the cluster supports it.
See the comment from @Ngone51
https://github.com/apache/spark/pull/30062#pullrequestreview-522224650
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
