venkata91 commented on a change in pull request #30062:
URL: https://github.com/apache/spark/pull/30062#discussion_r516948596
##########
File path:
common/network-common/src/main/java/org/apache/spark/network/util/TransportConf.java
##########
@@ -363,4 +363,39 @@ public boolean useOldFetchProtocol() {
return conf.getBoolean("spark.shuffle.useOldFetchProtocol", false);
}
+ /**
+ * Class name of the implementation of MergedShuffleFileManager that merges
the blocks
+ * pushed to it when push-based shuffle is enabled. By default, push-based
shuffle is disabled at
+ * a cluster level because this configuration is set to
+ *
'org.apache.spark.network.shuffle.ExternalBlockHandler$NoOpMergedShuffleFileManager'.
+ * To turn on push-based shuffle at a cluster level, set the configuration to
+ * 'org.apache.spark.network.shuffle.RemoteBlockPushResolver'.
+ */
+ public String mergedShuffleFileManagerImpl() {
+ return conf.get("spark.shuffle.push.based.mergedShuffleFileManagerImpl",
Review comment:
I liked the suggestion from @tgravescs here in this
[comment](https://github.com/apache/spark/pull/30164#discussion_r515289567)
which is to use `spark.shuffle.push.X` for push based shuffle introduced
configs.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
