HyukjinKwon commented on a change in pull request #30206:
URL: https://github.com/apache/spark/pull/30206#discussion_r517051642
##########
File path:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/features/KubernetesFeatureConfigStep.scala
##########
@@ -18,13 +18,17 @@ package org.apache.spark.deploy.k8s.features
import io.fabric8.kubernetes.api.model.HasMetadata
+import org.apache.spark.annotation.DeveloperApi
import org.apache.spark.deploy.k8s.SparkPod
/**
+ * :: DeveloperApi ::
+ *
* A collection of functions that together represent a "feature" in pods that
are launched for
* Spark drivers and executors.
*/
-private[spark] trait KubernetesFeatureConfigStep {
+@DeveloperApi
+trait KubernetesFeatureConfigStep {
Review comment:
Even for a developer API, we should make it Scala/Java friendly. That's
why I suggested to make it `@Unstable` (and make it better next time), or
properly consider Java interoperability. Also, using traits sometimes bring
some surprises when it comes to binary compatibility.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
