cloud-fan commented on pull request #30154: URL: https://github.com/apache/spark/pull/30154#issuecomment-721519171
I think the principle is: when users specify some table properties, JDBC V2 should fail if the underlying database can't support the properties. I prefer a dialect API to generate CREATE TABLE SQL statement, because `comment` is not the only table property. It's cumbersome to add one dialect API for each table property, like comment, charset, etc. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
