Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/5424#issuecomment-92048766
LGTM. This simplifies and standardizes the local host name logic across the
code, fixes the original problem of IPv6 addresses in URIs, chooses a better
local address in some IPv6 cases. Of course, making things consistent means
slight behavior changes in some cases -- for example, `customHostName` now
applies in cases it didn't before, but this actually seems more correct. I've
eyeballed every change and it looks logical, and the tests pass.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
