viirya commented on a change in pull request #30245:
URL: https://github.com/apache/spark/pull/30245#discussion_r517120205
##########
File path:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/SubexpressionEliminationSuite.scala
##########
@@ -149,17 +149,43 @@ class SubexpressionEliminationSuite extends SparkFunSuite
{
assert(equivalence.getAllEquivalentExprs.count(_.size == 1) == 3) // add,
two, explode
}
- test("Children of conditional expressions") {
- val condition = And(Literal(true), Literal(false))
+ test("Children of conditional expressions: If") {
Review comment:
I will add the tests for `CaseWhen` and `Coalesce`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
