mridulm commented on a change in pull request #30164:
URL: https://github.com/apache/spark/pull/30164#discussion_r517448830
##########
File path:
core/src/main/scala/org/apache/spark/storage/BlockManagerMasterEndpoint.scala
##########
@@ -657,6 +681,13 @@ class BlockManagerMasterEndpoint(
}
}
+ private def getShufflePushMergerLocations(
+ numMergersNeeded: Int,
+ hostsToFilter: Set[String]): Seq[BlockManagerId] = {
+ val mergers = shuffleMergerLocations.values.filterNot(x =>
hostsToFilter.contains(x.host)).toSeq
+ mergers.take(numMergersNeeded)
Review comment:
This is not prioritizing hosts with active executors right ?
Can we partition based on whether there are active executors or not, and use
that to ensure we pick `numMergersNeeded` mergers (and fallback to hosts
without mergers if not sufficient exists) ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
