dongjoon-hyun commented on a change in pull request #27735:
URL: https://github.com/apache/spark/pull/27735#discussion_r517800858



##########
File path: 
resource-managers/kubernetes/core/src/test/scala/org/apache/spark/deploy/k8s/features/BasicExecutorFeatureStepSuite.scala
##########
@@ -249,6 +249,18 @@ class BasicExecutorFeatureStepSuite extends SparkFunSuite 
with BeforeAndAfter {
       executor.container, SecurityManager.ENV_AUTH_SECRET))
   }
 
+  test("Mount spark driver's conf dir as configmap on executor pod's 
container.") {
+    val baseDriverPod = SparkPod.initialPod()
+    val kubernetesConf = KubernetesTestConf.createExecutorConf()
+
+    val step = new BasicExecutorFeatureStep(newExecutorConf(),
+      new SecurityManager(baseConf))

Review comment:
       Can we make this a single line?
   ```scala
   val step = new BasicExecutorFeatureStep(newExecutorConf(), new 
SecurityManager(baseConf))
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to