HeartSaVioR commented on a change in pull request #30096:
URL: https://github.com/apache/spark/pull/30096#discussion_r518041164
##########
File path:
resource-managers/yarn/src/main/scala/org/apache/spark/deploy/yarn/Client.scala
##########
@@ -1172,6 +1188,30 @@ private[spark] class Client(
}.mkString("")
}
+ /**
+ * Fetch links to the logs of the driver for the given application ID. This
requires hitting the
+ * RM REST API. Returns an empty map if the links could not be fetched. If
this feature is
+ * disabled via [[CLIENT_INCLUDE_DRIVER_LOGS_LINK]], an empty map is
returned immediately.
+ */
+ private def getDriverLogsLink(appId: ApplicationId): IMap[String, String] = {
+ if (!sparkConf.get(CLIENT_INCLUDE_DRIVER_LOGS_LINK)) {
+ return IMap()
+ }
+ val baseRmUrl = WebAppUtils.getRMWebAppURLWithScheme(hadoopConf)
Review comment:
I'd safely guard with try-catch and swallow the exception with logging
for whole this method (except if statement above) - IMHO this is to add
additional information, which is not major functionality to let the process
fail in the middle.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
