kiszk commented on pull request #26319: URL: https://github.com/apache/spark/pull/26319#issuecomment-722507551
For 1., I made a mistake. `Source.isJavaIdentifierPart()` except the first character. For 2., this code does not throw an exception. As you pointed out in [the JIRA entry](https://issues.apache.org/jira/browse/SPARK-29594), the following code would throw an exception at the Java code generation phase. The exception is not familiar with users. Can we provide the better message? ``` case class Foo(`1_something`: String) val test = Seq(Foo("HelloWorld!")).toDS() ``` ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
