Github user saucam commented on a diff in the pull request:
https://github.com/apache/spark/pull/5298#discussion_r28214791
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/parquet/ParquetTableSupport.scala
---
@@ -98,12 +98,32 @@ private[parquet] class RowReadSupport extends
ReadSupport[Row] with Logging {
val metadata = new JHashMap[String, String]()
val requestedAttributes =
RowReadSupport.getRequestedSchema(configuration)
+ // convert fileSchema to attributes
+ val fileAttributes =
ParquetTypesConverter.convertToAttributes(fileSchema, true, true)
--- End diff --
these booleans are for finding the datatype of the attribute, whereas here
we are just interested in finding out the names of the columns, to reconcile
with metastore schema. Hence it is safe to always send these parameters as
true, since we do not have SQL context here from which to derive these.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
