HyukjinKwon commented on a change in pull request #30274:
URL: https://github.com/apache/spark/pull/30274#discussion_r518543627
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/Encoders.scala
##########
@@ -146,7 +146,8 @@ object Encoders {
* - String
* - java.math.BigDecimal, java.math.BigInteger
* - time related: java.sql.Date, java.sql.Timestamp, java.time.LocalDate,
java.time.Instant
- * - collection types: only array and java.util.List currently, map support
is in progress
+ * - collection types: array, java.util.List, and map
+ * - map is only available since version 2.1.0
Review comment:
I think you can just remove this line. Spark versions<2.4 is EOL anyway
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/Encoders.scala
##########
@@ -146,7 +146,8 @@ object Encoders {
* - String
* - java.math.BigDecimal, java.math.BigInteger
* - time related: java.sql.Date, java.sql.Timestamp, java.time.LocalDate,
java.time.Instant
- * - collection types: only array and java.util.List currently, map support
is in progress
+ * - collection types: array, java.util.List, and map
+ * - map is only available since version 2.1.0
Review comment:
```suggestion
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
