AngersZhuuuu commented on a change in pull request #30212:
URL: https://github.com/apache/spark/pull/30212#discussion_r518590809
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/grouping.scala
##########
@@ -79,6 +79,29 @@ case class Cube(groupByExprs: Seq[Expression]) extends
GroupingSet {}
// scalastyle:on line.size.limit line.contains.tab
case class Rollup(groupByExprs: Seq[Expression]) extends GroupingSet {}
+// scalastyle:off line.size.limit line.contains.tab
+@ExpressionDescription(
+ usage = """
+ _FUNC_(([col1[, col2 ..]])*) - create a multi-dimensional grouping sets
using the specified columns
Review comment:
> We need `ExpressionDescription` for these grouping analytics exprs? We
already have documents for them though:
https://spark.apache.org/docs/3.0.1/sql-ref-syntax-qry-select-groupby.html
Don't need these after this pr.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
