Github user watermen commented on a diff in the pull request:

    https://github.com/apache/spark/pull/5290#discussion_r28216651
  
    --- Diff: 
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
 ---
    @@ -379,6 +381,33 @@ class Analyzer(catalog: Catalog,
         }
       }
     
    +  object ResolveSortAlias extends Rule[LogicalPlan] {
    +    def apply(plan: LogicalPlan): LogicalPlan = plan transform {
    +      case s @ Sort(ordering, global, a @ Aggregate(grouping, aggs, child))
    +          if !s.resolved && a.resolved =>
    +        val missingInAggs = new ArrayBuffer[NamedExpression]()
    +        val aliasedOrdering = ordering.zipWithIndex.map{
    +          case (o, i) => {
    +            o.child match {
    +              case aggOrSub @ (_: AggregateExpression | _: Substring) => {
    --- End diff --
    
    I have tested substring in newest version of spark.
    ```
    SELECT value, sum(key)
    FROM src
    GROUP BY value
    ORDER BY substr(value, 1, 5)
    ```
    is right.
    
    ```
    SELECT substr(value, 1, 5), sum(key)
    FROM src
    GROUP BY substr(value, 1, 5)
    ORDER BY substr(value, 1, 5)
    ```
    is wrong, and ERROR LOG is `cannot resolve 'value' given input columns _c0, 
_c1; line 4 pos 16`.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to