Github user viirya commented on the pull request:
https://github.com/apache/spark/pull/4996#issuecomment-92235526
After doing more search, I just found that because `Average` is a
`PartialAggregate`, we never get a `Average` node when reaching
`HashAggregation` to prepare `GeneratedAggregate`. So we don't need to add
`Average` as this pr did.
That is why in SQLQuerySuite there is already a test for `avg` with
codegen. And it works.
What interesting is that we can find a case in `GeneratedAggregate` to deal
with `Average`. Based on the above, we actually never execute this case.
So I would like to remove this case from `GeneratedAggregate`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
