Github user sryza commented on a diff in the pull request:
https://github.com/apache/spark/pull/5449#discussion_r28218090
--- Diff:
yarn/src/main/scala/org/apache/spark/deploy/yarn/YarnAllocator.scala ---
@@ -94,6 +98,14 @@ private[yarn] class YarnAllocator(
// Additional memory overhead.
protected val memoryOverhead: Int =
sparkConf.getInt("spark.yarn.executor.memoryOverhead",
math.max((MEMORY_OVERHEAD_FACTOR * executorMemory).toInt,
MEMORY_OVERHEAD_MIN))
+
+ // Make the maximum executor failure check to be relative with respect
to duration
+ private val relativeMaxExecutorFailureCheck =
--- End diff --
@srowen if you're suggesting tying it to the dstream window I think that
could be confusing. It doesn't seem obvious to me that these should be
proportional.
Another thing is that it seems confusing that, if I want to set a max
failures per time interval, I need to set three different properties. It's
also worth considering just adding a
`spark.yarn.max.executor.failuresPerMinute` property.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
