viirya commented on pull request #30245: URL: https://github.com/apache/spark/pull/30245#issuecomment-723199081
> Do you still remember why "subexpression elimination" must be eagerly executed? Because implementing "lazy" is expensive? I don't remember if we have tried to implement "lazy" behavior in codegen. Looks like at least it will bring complex as we need extra variable to check if a subexpression is evaulated in first time. Every time we use a subexpression, we might need to first check the extra variable and decide to evaluate the subexpression or just use evaluated value. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
