maropu commented on a change in pull request #30280:
URL: https://github.com/apache/spark/pull/30280#discussion_r519052876
##########
File path:
sql/core/src/test/resources/sql-tests/inputs/subquery/in-subquery/in-joins.sql
##########
@@ -6,8 +6,8 @@
-- 2. run with whole-stage-codegen, operator codegen or no codegen.
--CONFIG_DIM1 spark.sql.autoBroadcastJoinThreshold=10485760
---CONFIG_DIM1
spark.sql.autoBroadcastJoinThreshold=-1,spark.sql.join.preferSortMergeJoin=true
---CONFIG_DIM1
spark.sql.autoBroadcastJoinThreshold=-1,spark.sql.join.preferSortMergeJoin=false
+--CONFIG_DIM1
spark.sql.autoBroadcastJoinThreshold=10485760,spark.sql.join.preferSortMergeJoin=true
+--CONFIG_DIM1
spark.sql.autoBroadcastJoinThreshold=10485760,spark.sql.join.preferSortMergeJoin=false
Review comment:
Thanks for pinging me, @dongjoon-hyun. IMO it might be worth adding a
new directive (e.g., `--JOIN_TYPE`?) for controlling physical join plans
correctly via the hint logic in this test suite;
https://github.com/apache/spark/blob/e11a24c1ba5b0f3116b46a213443902165919da5/sql/core/src/test/scala/org/apache/spark/sql/SQLQueryTestSuite.scala#L70-L88
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
