ScrapCodes commented on pull request #27735:
URL: https://github.com/apache/spark/pull/27735#issuecomment-723458969
>Do we need to rename SecretVolumeUtils.scala to K8sVolumeTestUtils?
Actually, the code is still using SecretVolumeUtils.podHasVolume because we
didn't change the class name. If you don't mind, shall we keep the original
file name?
Hi @dongjoon-hyun , I have already reverted this change. Actually, I did
this change initially, because `SecretVolumeUtils.podHasVolume` is used at more
places than it was initially intended and the name `Secret` has no relevance
anymore. But, we can tackle this in a separate patch.
I did another pass to see if all the comments are addressed. Do you think,
I am missing something?
Thanks !
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
