HyukjinKwon commented on a change in pull request #30281:
URL: https://github.com/apache/spark/pull/30281#discussion_r519511433
##########
File path: core/src/main/scala/org/apache/spark/api/python/PythonUtils.scala
##########
@@ -29,14 +29,9 @@ import org.apache.spark.api.java.{JavaRDD, JavaSparkContext}
private[spark] object PythonUtils {
val PY4J_ZIP_NAME = "py4j-0.10.9-src.zip"
- /** Get the PYTHONPATH for PySpark, either from SPARK_HOME, if it is set, or
from our JAR */
+ /** Get the PYTHONPATH for PySpark from our JAR */
def sparkPythonPath: String = {
val pythonPath = new ArrayBuffer[String]
- for (sparkHome <- sys.env.get("SPARK_HOME")) {
- pythonPath += Seq(sparkHome, "python", "lib",
"pyspark.zip").mkString(File.separator)
- pythonPath +=
- Seq(sparkHome, "python", "lib", PY4J_ZIP_NAME).mkString(File.separator)
- }
Review comment:
I would just leave this code for simplicity.
> If local machine has different version of both files
How would this happen? pyspark.zip and py4j.zip are built-in in Spark.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
