cloud-fan commented on a change in pull request #30296:
URL: https://github.com/apache/spark/pull/30296#discussion_r519673617
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala
##########
@@ -1966,7 +1966,7 @@ case class ElementAt(left: Expression, right: Expression)
}
override def nullable: Boolean = left.dataType match {
- case _: ArrayType => computeNullabilityFromArray(left, right)
+ case _: ArrayType => computeNullabilityFromArray(left, right,
isOneBasedIndex = true)
Review comment:
Got it. Then `isOneBasedIndex` is a misleading name. Maybe the parameter
should be `normalizeIndex: (Int, Int) => Int = _._2`, which takes the array
length and the index, and return the normalized 0-based non-negative index.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
