AngersZhuuuu commented on a change in pull request #30278:
URL: https://github.com/apache/spark/pull/30278#discussion_r519918205
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
##########
@@ -1269,6 +1269,7 @@ object PushPredicateThroughNonJoin extends
Rule[LogicalPlan] with PredicateHelpe
case _: Sort => true
case _: BatchEvalPython => true
case _: ArrowEvalPython => true
+ case _: Expand => true
Review comment:
> I'm sorry I didn't get it. What's the issue here? We can't pushdown
left-semi join through expand?
I just want to show, since we can push down left-semi join through expand,
so we won't meet case impacted by `canPushThrough` after add `case _: Expand
=> true` in `PushDownLeftSemiAntiJoin ` . So we can't write a test about
https://github.com/apache/spark/pull/30278/files#r519674067 to show the
influence about. comment
https://github.com/apache/spark/pull/30278#discussion_r519503774.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
